Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Storage: Newtype for Database Volume/Content types #14885

Draft
wants to merge 15 commits into
base: main
Choose a base branch
from
Draft

Storage: Newtype for Database Volume/Content types #14885

wants to merge 15 commits into from

Conversation

MggMuggins
Copy link
Contributor

This:

  • Communicates intent via a variable's type, not just its name
  • Prevents accidental assignment of e.g. a volume type where a content type was expected
  • Enforces the type safety at the database boundary; any type IDs coming out of the database layer can be assumed to be correct
  • Provides convenient conversions using Name()

@MggMuggins
lxd/db/cluster: Add StoragePoolVolumeType newtype
7c3742d 
Signed-off-by: Wesley Hershberger <[email protected]>
@MggMuggins
lxd/db/cluster: Add StoragePoolVolumeContentType newtype
9e27cfd 
Signed-off-by: Wesley Hershberger <[email protected]>
@MggMuggins
lxd/db: Validate newtypes from DB
0bced8d 
Enforce the type safety invariants for pool volume/content types as the
values are queried from the DB so that downstream code can assume that
their values are valid.

Signed-off-by: Wesley Hershberger <[email protected]>
@MggMuggins
lxd/storage: Use StoragePoolVolumeType
e0dd470 
Signed-off-by: Wesley Hershberger <[email protected]>
@MggMuggins
lxd/db: Use StoragePoolVolumeType for query params
197974d 
Signed-off-by: Wesley Hershberger <[email protected]>
@MggMuggins
lxd/project: Use StoragePoolVolumeType
c3a3d4f 
Signed-off-by: Wesley Hershberger <[email protected]>
@MggMuggins
lxd/device: Use StoragePoolVolumeType
e431d16 
Signed-off-by: Wesley Hershberger <[email protected]>
@MggMuggins
lxd/instance/drivers: Use StoragePoolVolumeType.Name
f0b26ef 
Signed-off-by: Wesley Hershberger <[email protected]>
@MggMuggins
lxd: Use StoragePoolVolumeType
da88c04 
Signed-off-by: Wesley Hershberger <[email protected]>
@MggMuggins
lxd/db: Use StoragePoolVolumeContentType
a7e64f1 
Signed-off-by: Wesley Hershberger <[email protected]>
@MggMuggins
lxd/storage: Use StoragePoolVolumeContentType
1fb3e0b 
Signed-off-by: Wesley Hershberger <[email protected]>
@MggMuggins
lxd/storage: Replace VolumeTypeNameToDBType with StoragePoolVolumeTyp…
7a17e7f 
…eFromName

Signed-off-by: Wesley Hershberger <[email protected]>
@MggMuggins
lxd: Replace VolumeTypeNameToDBType with StoragePoolVolumeTypeFromName
a1dad6c 
Signed-off-by: Wesley Hershberger <[email protected]>
@MggMuggins
lxd/db/test: Use StoragePoolVolumeType
8e199e9 
Signed-off-by: Wesley Hershberger <[email protected]>
@MggMuggins
lxd/test: Fix misused ContentType constant
c41c1c6 
Signed-off-by: Wesley Hershberger <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@MggMuggins